Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 )

Change subject: context map: introduce RUA and SCCP FSMs to fix leaks
......................................................................


Patch Set 1:

(3 comments)

File include/osmocom/hnbgw/context_map.h:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3837):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/f2395e5b_6e138186
PS1, Line 35:   /* Something disruptive occured elsewhere than RUA, we want to 
clean up the RUA conn and be gone. */
'occured' may be misspelled - perhaps 'occurred'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3837):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/19fb060c_ea135733
PS1, Line 58:   /* Something disruptive occured elsewhere than SCCP, we want to 
clean up the SCCP conn and be gone. */
'occured' may be misspelled - perhaps 'occurred'?


File src/osmo-hnbgw/hnbgw_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-3837):
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/587c639d_75c4f6ef
PS1, Line 212:          state_count[map->is_ps? 1 : 
0][context_map_get_state(map)]++;
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19
Gerrit-Change-Number: 31431
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 21 Feb 2023 03:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to