Attention is currently required from: laforge, pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431 )

Change subject: context map: introduce RUA and SCCP FSMs to fix leaks
......................................................................


Patch Set 6:

(3 comments)

Patchset:

PS5:
> Maybe I can spend yet another hour to see if I can split off very simple 
> things. […]
hope it's easier to review now


File include/osmocom/hnbgw/context_map.h:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/ce0c1433_7de81119
PS5, Line 22: enum map_rua_fsm_event {
> (hold on, the PLEASE_DISCONNECT should not be there anymore. […]
i tweaked the naming to include 'REQUEST' and 'INDICATION', hope that's good


File src/osmo-hnbgw/hnbgw_rua.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431/comment/47c67382_58c2a19f
PS5, Line 183:  { RUA_ProcedureCode_id_Connect, "id-Connect" },
> ah ok, was not aware of that!
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/31431
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I6ff7e36532ff57c6f2d3e7e419dd22ef27dafd19
Gerrit-Change-Number: 31431
Gerrit-PatchSet: 6
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 24 Feb 2023 00:33:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to