Attention is currently required from: fixeria, pespin, msuraev. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31415 )
Change subject: bts_features: Add features for HR formats (TS 101813 vs. RFC5993) ...................................................................... Patch Set 8: (2 comments) File include/osmocom/gsm/bts_features.h: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/294d4ae9_9319f923 PS7, Line 39: _TX > IMO, the '_TX_' part should be removed. […] The BTS will accept both formats since it is easy to detect and convert from one to the other. So the BTS will not care. However the BTS will still transmit in one of the two formats. That why we opted to have a _TX_ in the name. File src/gsm/bts_features.c: https://gerrit.osmocom.org/c/libosmocore/+/31415/comment/5376aab1_a4b18fe7 PS7, Line 49: { BTS_FEAT_VBS, "Voice Broadcast Service" }, > That's a duplicate from the entry above. Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043 Gerrit-Change-Number: 31415 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: msuraev <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: msuraev <[email protected]> Gerrit-Comment-Date: Fri, 24 Feb 2023 13:47:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: msuraev <[email protected]> Gerrit-MessageType: comment
