Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214 )
Change subject: mgcp_sdp: add fmtp string to define HR GSM RTP format ...................................................................... Patch Set 10: (4 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/b7f7d957_a0203c85 PS10, Line 705: case GSM_HR_BYTES + sizeof(struct rtp_hdr): if possible order the fields left to right based on the order you encounter them in the pkt. https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/94877e38_ee6f532d PS10, Line 741: bool convert = false; can be dropped. https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/59257e91_d17bf92c PS10, Line 746: convert = true; return true; https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/8fa69cd4_49258296 PS10, Line 750: convert = true; return true; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31214 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idde8da27fd335dc03b8fbd9e0fedc1491b77e9e4 Gerrit-Change-Number: 31214 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Tue, 28 Feb 2023 13:36:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
