Attention is currently required from: fixeria.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31678 )

Change subject: pcu_sock: fix PCU socket accept behavior
......................................................................


Patch Set 1:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/31678/comment/c858cbea_ebae2661
PS1, Line 10: then the new connection should replace the old one
> This is weird, I am surprised we're doing it this way. […]
Thanks for your input. That was the best I could think of at the moment, we 
could also do one of the following:

Accept the connection and then actively reject it by closing the socket 
immediately?

Check early in the function if there is already a connection and then just 
return without doing anything? (as far as I remember @pespin suggested to do 
that)

What do you think?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I695b93fd8109ef4943f36716563c147927611e85
Gerrit-Change-Number: 31678
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Mon, 06 Mar 2023 15:23:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to