Attention is currently required from: msuraev, dexter.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/31678 )

Change subject: pcu_sock: fix PCU socket accept behavior
......................................................................


Patch Set 2:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/31678/comment/0f687ed6_df225735
PS1, Line 10: then the new connection should replace the old one
> Thanks for your input. […]
One approach is to `accept()` a new connection and then immediately `close()` 
if there is already an active one. Another approach is to disable read events 
on the listening socket by calling `osmo_fd_read_disable(&listen_bfd)` when we 
get the first connection - this is what osmo-bsc does, AFAICS.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31678
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I695b93fd8109ef4943f36716563c147927611e85
Gerrit-Change-Number: 31678
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: msuraev <[email protected]>
Gerrit-Attention: msuraev <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Mar 2023 01:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to