Attention is currently required from: dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/31737 )

Change subject: pcu_l1_if: do not copy IMSI when it is NULL
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/31737/comment/6a5fa429_2bf8b2d5
PS1, Line 306:          strcpy(pch_dt.imsi, imsi);
this should probably be OSMO_STRLCPY_ARRAY() btw (not necessarily in this 
patch).



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31737
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9192d50dd78be0a72ffdb9bfb9ed66aef085bcf1
Gerrit-Change-Number: 31737
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Mar 2023 17:45:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to