Patch Set 1:
> > have you verified that these tools work as expected in both py2
> and py3?
>
> py2 is verified in gerrit 5277, py3 verification is added in
> follow-up patch.
We do not have comprehensive automatic testing of these scripts anywhere, so it
would involve manual testing.
Hence I would welcome a rationale: why does this *need* py3 in the first place?
"necessary for proper py3 tests" doesn't explain it to me. Why is it necessary
in particular?
I would be more comfortable sticking with py2 where we have it, and for new
projects use the fully-py3 osmo_interact_* code instead.
> > will no longer work in py2
>
> it works for me but we should first merge the jenkins integration
> and than let it be tested automatically.
IIUC it cannot possibly work, since in py2 the syntax is completely different.
Your change will print a tuple or something, but I wonder whether ('abc',
file=xyz) is actually valid tuple syntax.
You are of course aware that it's not like C where errors are caught
immediately, in py you have to hit the actual code path to be sure that the
syntax has the desired effect. Have you *really* tested it and checked the
output?
--
To view, visit https://gerrit.osmocom.org/5280
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60
Gerrit-PatchSet: 1
Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-HasComments: No
