Patch Set 1: > We do not have comprehensive automatic testing of these scripts anywhere
We don't have any testing, that's why I've added basic tests in https://gerrit.osmocom.org/#/c/5277/ > why does this *need* py3 in the first place? "necessary for proper py3 tests" > doesn't explain it to me. If we have code which requires python3 than it have to be tested with python3. But before we commit those we have to first make sure the tests are passed. That's what this patch does. > Have you *really* tested it and checked the output? This is completely pointless discussion. The tests have to be run automatically by jenkins for each commit. If you think that the test coverage is insufficient than we have to expand tests first. Either way, https://gerrit.osmocom.org/#/c/5277/ have to be reviewed and merged first. -- To view, visit https://gerrit.osmocom.org/5280 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 Gerrit-PatchSet: 1 Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: No
