Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 )
Change subject: sip: log release caused by status >= 300 as error ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > maybe NOTICE could be better there? But isn't it an error? it's not successful, that would be 2xx. 3xx is for redirection responses that we don't handle (and so I would say it's also an error as it leads to dropping the call), and 4xx, 5xx, 6xx are errors from client/server/global. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164 Gerrit-Change-Number: 32018 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 22 Mar 2023 14:37:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
