Attention is currently required from: osmith, neels, fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018 )

Change subject: sip: log release caused by status >= 300 as error
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1:
according to the spec >= 400 is an error. "300 <= x < 400" is a redirect.

So printing an ERROR for the range 300..399 is wrong.  We might print some 
notice that we're not implementing redirects, but that's not an error.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/32018
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I64889d6ce174dc17d44d85aac12e7ee6e6b06164
Gerrit-Change-Number: 32018
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 23 Mar 2023 08:50:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to