Attention is currently required from: pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/32085 )

Change subject: msc_main: close SMS db on startup error
......................................................................


Patch Set 2:

(2 comments)

File src/osmo-msc/msc_main.c:

https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/49f431fb_de36029c
PS1, Line 805:                  db_fini();
> really looks like you want to use a goto here....
Done


https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/58b44ff4_ae0949ac
PS1, Line 829:  db_fini();
> to here....
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32085
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459
Gerrit-Change-Number: 32085
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 04 Apr 2023 11:30:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to