Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/32085 )
Change subject: msc_main: close SMS db on startup error ...................................................................... Patch Set 2: (2 comments) File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/9f677332_855f6882 PS2, Line 745: sms_queue_start > BTW, can we move the DB init down below? Not saying this must be done, but I > think this would simpli […] I'll leave this as-is because sqlite is on its way out (https://osmocom.org/issues/5559) https://gerrit.osmocom.org/c/osmo-msc/+/32085/comment/9a34a5f8_430be071 PS2, Line 832: error_close_sms_db > AFAICS, `db_fini()` can be called at any time, even if the database is not > initialized. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/32085 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9bb799048db5fcdb2a2520107bd75d5f7a865459 Gerrit-Change-Number: 32085 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 09:33:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
