Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32212 )

Change subject: NM: NACK received OML OPSTART if no attributes were set 
beforehand
......................................................................


Patch Set 2:

(2 comments)

File src/common/nm_bb_transc_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/ff0b83d1_8a8f0b85
PS2, Line 139: SITE_MGR
> You meant BASEBAND TRANSCEIVER here? […]
as per TS 12.21 there may not be, but extensions can still be added. that's the 
case for ipa in site_mgr (we never implemented them in osmo-bts/bsc oursleves 
so far afacit).


File src/common/nm_bts_sm_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/8ed2539b_ffd3562f
PS2, Line 103: SITE_MGR
> Are there any attributes for it in the OML spec? […]
See my other comment.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32212
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I771ecc2f60873a3549e8a07a2e57c7948dfc993e
Gerrit-Change-Number: 32212
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 05 Apr 2023 10:21:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to