Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32212 )
Change subject: NM: NACK received OML OPSTART if no attributes were set beforehand ...................................................................... Patch Set 2: (1 comment) File src/common/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/03d18dd7_1612a0bb PS2, Line 139: SITE_MGR > as per TS 12.21 there may not be, but extensions can still be added. IMO, adding dead code with hypothetical applicability (maybe in the future, maybe not) is not a good idea. One can always add this whenever needed. Your comment in the code "osmo-bsc doesn't send SetAttr" makes it even more confusing, as if osmo-bsc (or any other BSC) is expected to do so but does not for some reason. Unless you're actually planning to implement any extensions, please either remove this block of code or at least make the comment less confusing, e.g. "no attributes defined in section 6.5" or so. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I771ecc2f60873a3549e8a07a2e57c7948dfc993e Gerrit-Change-Number: 32212 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 05 Apr 2023 11:30:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
