Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32240 )
Change subject: Move GPRS NSE under BTS SiteMgr ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/bts_sm.h: https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/4e462ef5_7d6c4ca6 PS1, Line 43: gprs `pcu_state` is also related to GPRS, but not part of this struct. Do we really need to anonymous struct? Can we just call the new field `gprs_nse` instead? File src/common/bts_sm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/020292e7_823a94b8 PS1, Line 77: %d", 0 just have `0` in the format string and use `osmo_fsm_inst_update_id()`? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If44d8f256cab7b2660900cedfb0ed9fe67eb3420 Gerrit-Change-Number: 32240 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 10 Apr 2023 19:39:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
