Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32240 )
Change subject: Move GPRS NSE under BTS SiteMgr ...................................................................... Patch Set 1: (2 comments) File include/osmo-bts/bts_sm.h: https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/7d832391_069306d3 PS1, Line 43: gprs > `pcu_state` is also related to GPRS, but not part of this struct. […] I liked having the .gprs suffix in the previous place, so I'm keeping here. We can move pcu_state to .gprs later on in another commit. File src/common/bts_sm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32240/comment/bbd58577_7b9eb955 PS1, Line 77: %d", 0 > just have `0` in the format string and use `osmo_fsm_inst_update_id()`? Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If44d8f256cab7b2660900cedfb0ed9fe67eb3420 Gerrit-Change-Number: 32240 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 11 Apr 2023 09:01:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
