Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32236 )
Change subject: Merge gsm_network into gsm_bts_sm and place gsm_bts under it ...................................................................... Patch Set 5: Code-Review+1 (4 comments) File src/common/bts.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/4964755f_ae6cc6c6 PS4, Line 406: g_bts_sm->num_bts++; > This change would not be part of this patch however, I'll fix it in a > followup patch. Done https://gerrit.osmocom.org/c/osmo-bts/+/32262. File src/common/bts_sm.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/cd291f02_0b2c12e8 PS4, Line 37: talloc_free > I prefer doing it this way in order to control the order of stuff being freed. Done File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/7be6a4d1_87af8346 PS4, Line 154: if (!bts) { > Ack Done File src/common/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bts/+/32236/comment/562cbc93_3529b683 PS4, Line 957: struct gsm_bts_sm *bts_sm > Yes we could, I'm not sure if it makes sense doing it in this commit or not, > I simply changed the mi […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32236 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ideb0d458ec631008223f861cf8b46d09524a1a21 Gerrit-Change-Number: 32236 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 11 Apr 2023 09:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
