Attention is currently required from: neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 )

Change subject: SCCP: implement variable limit on Optional Data 
(CR,CC,CREF,RLSD)
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3:
> I do wonder, shouldn't this be done per sccp-address and not globally for the 
> entire instance? This  […]
Sorry I copy-pasted wrong, see the correct snippet:
```
cs7 instance 0
 point-code 0.0.2
 asp asp0 2905 0 m3ua
  !local-ip 192.168.30.100
  !local-ip 192.168.30.1
  local-ip 127.0.0.2
  !local-ip 0.0.0.0
  local-ip ::1
  !remote-ip 192.168.30.220
  !remote-ip 192.168.30.1
  remote-ip 127.0.0.1
  remote-ip ::1
 as as0 m3ua
  asp asp0
  routing-key 30 0.0.2
  traffic-mode loadshare
 sccp-address bsc_local
  point-code 0.0.2
  routing-indicator PC
 sccp-address msc_remote
  point-code 0.23.1
  routing-indicator PC
  max-optional-data 300 // ADDED HERE!!!!!!!!!!!
msc 0
 ...
 msc-addr msc_remote
 bsc-addr bsc_local
```



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32361
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If35697234796af8943691b2de62218e7dc93a08c
Gerrit-Change-Number: 32361
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Mon, 24 Apr 2023 16:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to