Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 )
Change subject: SCCP: implement variable limit on Optional Data (CR,CC,CREF,RLSD) ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Sorry I copy-pasted wrong, see the correct snippet: […] IMO that is far too fine-grained, it's the very wrong place to put this low level SCCP config in every single osmo_sccp_address. Having this configured per SCCP instance is exactly the right spot. Consider this: when I have one peer that needs a lower limit on the optional data, it is not harmful if we also use that lower limit with another peer that would be fine with the full 130. If the user wants separate limits on separate peers, she can still set up separate cs7 instances. But, I assume that this problem is not common -- we can rightfully expect peers to adhere to the SCCP spec, and as we introduce this workaround here, let's not go overboard with effort to make this super fine grained. (I am actually surprised to even see this problem in the field, with a commercial SGSN peer nonetheless... that product must have interop issues everywhere, and really they should fix the SGSN instead.) -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/32361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: If35697234796af8943691b2de62218e7dc93a08c Gerrit-Change-Number: 32361 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 19:59:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
