Attention is currently required from: laforge, keith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )
Change subject: e1d: reconnect to osmo-e1d after connection loss ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > I don't have the full picture nor the time right now (on holidays) to > investigate fully. […] I think for the Keith's specific application it would be better to use the DAHDI driver. I wasn't aware of that this would be the preferred solution for applications that use libosmo-abis. In its current state the API requires the API user to keep track of the file descriptors and close them if necessary. I would say its probably the better option to merge this patch as it is. It is definitely an improvement and we can split it off later if we really need to. As far as I can see osmo-e1d-pipe is currently the only other application that uses osmo-e1d directly through its proto_clnt.h API. e1d-ts-pipe.c:ts_fd_cb() would exit if there is a problem accessing a file descriptor of the TS, so this would at least not hang with 100% CPU usage. I wonder if there is other software like this. The manual suggests that an application should go via libosmo-abis. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338 Gerrit-Change-Number: 32374 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: keith <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: tnt <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: keith <[email protected]> Gerrit-Comment-Date: Tue, 25 Apr 2023 12:26:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: keith <[email protected]> Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
