Attention is currently required from: neels, dexter.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/32218 )

Change subject: mgcp_codec: fix codec decision
......................................................................


Patch Set 9:

(2 comments)

Patchset:

PS9:
It looks fine for me so far, let me know if I should join the discussion.


File src/libosmo-mgcp/mgcp_codec.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/32218/comment/e66f7fc6_5ff8ce2c
PS9, Line 384:  /* In case we weren't able to find an exact match, we will try 
to find a match that is the same codec, but the
You can do early return here:

codec_convertible = mgcp_codec_find_same(conn, codec);
if (codec_convertible)
    return codec_convertible;



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/32218
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I6c3291f825488e5d8ce136aeb18450156794aeb5
Gerrit-Change-Number: 32218
Gerrit-PatchSet: 9
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 26 Apr 2023 16:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to