Attention is currently required from: osmith, fixeria, daniel.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679 )

Change subject: hnbgw: put copyright into define
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
this is really weird, given that we have this "const char * foo_copyright" in 
pretty much all our projects, don't we?

A quick grep shows the same approach in osmo-gbproxy (const char *), osmo-ggsn 
(static const char foo[]), osmo-hlr (static const char foo[]), osmo-hnodeb 
(static const char * const foo), osmo-mgw, osmo-msc, osmo-pcap, osmo-pcu, 
osmo-sgsn, osmo-trx, ...



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I13b2569a369724e0298b064a0876b95d6dafd9d0
Gerrit-Change-Number: 32679
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 10 May 2023 10:45:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to