Attention is currently required from: laforge, fixeria, daniel.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679 )

Change subject: hnbgw: put copyright into define
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> this is really weird, given that we have this "const char * foo_copyright" in 
> pretty much all our pr […]
The difference is, we write it into vty_info.copyright in main():

https://gitea.osmocom.org/cellular-infrastructure/osmo-gbproxy/src/commit/5788f73ee81131b3202e23866ef0633a844d7db0/src/gb_proxy_main.c#L284

This also was the case in osmo-hnbgw before 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/32620.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/32679
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I13b2569a369724e0298b064a0876b95d6dafd9d0
Gerrit-Change-Number: 32679
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Wed, 10 May 2023 10:48:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to