Attention is currently required from: laforge.

matanp has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/32686 )

Change subject: cards: Add support for Gialer SIM cards
......................................................................


Patch Set 1:

(2 comments)

File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/32686/comment/3ed96c3e_3e111ccf
PS1, Line 1668:     def autodetect(kls, scc):
> isn't it possible to auto-detect the cards based on ATR or some other 
> criteria?
Unfortunately I don't have other sims to check for false positives (and I 
couldn't find any documentation about it)


https://gerrit.osmocom.org/c/pysim/+/32686/comment/6d7de4fa_785edf55
PS1, Line 1700:
> are you sure there aren't various other files you'd need to program?  Like 
> EF. […]
>From what I understand (captured https://smacarte.com/wp/grsimwrite_download/ 
>usb traffic) the K and the Ki are same in this sim. I will add the OPC (no OP 
>option) and the AD soon



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32686
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icd2021aec630ac018f66ab565e03112047389e17
Gerrit-Change-Number: 32686
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 11 May 2023 12:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to