Attention is currently required from: fixeria, matanp. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32565 )
Change subject: ctrl: Add getting neighbor list ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/61a28a26_aa08380c PS3, Line 531: cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 ? "%u" : " %u", i); > 1-In my opinion "rf_states", "channel-load", "rach-access-control-classes" > and "neighbor-bts list" k […] 1- Ok I was unaware of other commands using something other than spaces. I think it makes sense to have them standarized. @laforge feedback from you here would be welcome. 2- if it's using realloc then I think it's fine enough. THough I agree that if you know the maximum size (not sure where 4009 comes from), then simply allocate that buffer and use OSMO_STRBUF_APPEND. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7 Gerrit-Change-Number: 32565 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: matanp <[email protected]> Gerrit-Comment-Date: Tue, 16 May 2023 08:12:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: matanp <[email protected]> Gerrit-MessageType: comment
