Attention is currently required from: pespin, fixeria.

matanp has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/32565 )

Change subject: ctrl: Add getting neighbor list
......................................................................


Patch Set 4:

(1 comment)

File src/osmo-bsc/bts_ctrl.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/32565/comment/c641a7e7_93b608ac
PS3, Line 531:          cmd->reply = talloc_asprintf_append(cmd->reply, i == 0 
? "%u" : " %u", i);
> I'd rather go for 1 allocation of 4096 bytes than potentially doing 1024 
> allocations, even if used w […]
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32565
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icba0b7d92f4c67e617d707ca651d674f0d1ba8a7
Gerrit-Change-Number: 32565
Gerrit-PatchSet: 4
Gerrit-Owner: matanp <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 16 May 2023 10:44:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Comment-In-Reply-To: matanp <[email protected]>
Gerrit-MessageType: comment

Reply via email to