Attention is currently required from: falconia, dexter.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32740 )

Change subject: gsm630: make osmo_hr_check_sid compatible with RFC 5993
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I am also somewhat uncertain if we really need this flexibility.

> Wouldn't it be much cleaner to check the RTP encoding format ...

FYI: osmo-bts-trx already does this in some places, for instance:

https://cgit.osmocom.org/osmo-bts/tree/src/osmo-bts-trx/sched_lchan_tchh.c?id=0eb90a0a98751b775d25cc0b975a9b3a987400a8#n189



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32740
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I25728299b757fbc87dd1b3f5adaec9b8b240c5d1
Gerrit-Change-Number: 32740
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: falconia <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: falconia <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Wed, 17 May 2023 14:24:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia <[email protected]>
Gerrit-MessageType: comment

Reply via email to