Attention is currently required from: falconia, pespin.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/32970 )

Change subject: all models, HR1 codec: select RTP output format via vty option
......................................................................


Patch Set 1:

(1 comment)

File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/d68ed8a2_04110204
PS1, Line 802: DEFUN(cfg_bts_rtp_hr_format,
As far as I can see the bts->emit_hr_rfc5993 is checked on every l1sap_tch_ind. 
This means the VTY setting is immediately applied. So you can use EFUN_ATTR 
with CMD_ATTR_IMMEDIATE (see code below)

(The attributes are used for auto generating documentation)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e
Gerrit-Change-Number: 32970
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pma...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: falconia <fal...@freecalypso.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 24 May 2023 15:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to