Attention is currently required from: laforge, pespin, dexter. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32970 )
Change subject: all models, HR1 codec: select RTP output format via vty option ...................................................................... Patch Set 1: (3 comments) File include/osmo-bts/bts.h: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/77bbed4e_7ea9a729 PS1, Line 303: bool emit_hr_rfc5993; > maybe an enum specific type would be better here, but not sure if such an > enum exists already. There is no existing enum. If such enum did already exist, I would certainly use it, but do we really need to go to the trouble of creating one just for this purpose? File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/e190af5d_fe5b066e PS1, Line 1705: send_rtp_rfc5993(lchan, fn, msg->data, msg->len); > agreed. Let's be smart in msgb usage rathe than andding memcpy/memmove/... Good point. I shall investigate to make sure that the necessary headroom does exist, and then make the change. File src/common/vty.c: https://gerrit.osmocom.org/c/osmo-bts/+/32970/comment/fd0cbe4d_3fc3971c PS1, Line 802: DEFUN(cfg_bts_rtp_hr_format, > As far as I can see the bts->emit_hr_rfc5993 is checked on every > l1sap_tch_ind. […] Point taken - I shall look into doing what you suggest. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32970 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I168191874a062429a57904511a1e89e3f588732e Gerrit-Change-Number: 32970 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pma...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 24 May 2023 17:48:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: dexter <pma...@sysmocom.de> Gerrit-MessageType: comment
