Attention is currently required from: merlinchlosta, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/32688 )

Change subject: docs: add SUPI/SUCI usage example
......................................................................


Patch Set 3:

(5 comments)

Patchset:

PS1:
> thanks for submitting it. […]
Done


File docs/suci-tutorial.rst:

https://gerrit.osmocom.org/c/pysim/+/32688/comment/396b6a96_48cf5968
PS1, Line 6: . pySIM
> probably makes sense to mention the two different fundamental ways of SUCI 
> calculation (on card / on […]
Done


https://gerrit.osmocom.org/c/pysim/+/32688/comment/2555e4e5_b0a5edfe
PS1, Line 33:  If you bought
            : the SIM card from your network
> maybe make it more explicit that this only works with a programmable card 
> where you as the pySim use […]
Done


https://gerrit.osmocom.org/c/pysim/+/32688/comment/cd05fbb9_49cb477f
PS1, Line 103: file is **invalid**:
> does the file contain invalid data, or do you mean it is invalidated (other 
> term for deactivated)?
Done


https://gerrit.osmocom.org/c/pysim/+/32688/comment/f75efe47_7c6e78be
PS1, Line 168: sysmocom ISIM does
> best to always say "sysmoISIM-SJA2" as other products in the future may also 
> be a "sysmocom ISIM" bu […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32688
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2908ea9df7e78c596554731085902e2ab7278328
Gerrit-Change-Number: 32688
Gerrit-PatchSet: 3
Gerrit-Owner: merlinchlosta <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: merlinchlosta <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 25 May 2023 08:08:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: merlinchlosta <[email protected]>
Gerrit-MessageType: comment

Reply via email to