Attention is currently required from: merlinchlosta. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32688 )
Change subject: docs: add SUPI/SUCI usage example ...................................................................... Patch Set 1: (6 comments) Patchset: PS1: > Harald suggested including the "SUCI tutorial"[1] into the official > documentation, so I thought a pu […] thanks for submitting it. I'll put on my todo list to remove the whitespaces which the linter complains about. side note: ISIM-SJA2 is going EOL soon (we still have ~ 11,000 in stock for the next few months) and I'm currently working on the successor product which will (at least in one variant with a more beefy processor in the card for the EC crypto) also support the "SUCI calculation on SIM". File docs/suci-tutorial.rst: https://gerrit.osmocom.org/c/pysim/+/32688/comment/53adbb55_ce145e10 PS1, Line 6: . pySIM probably makes sense to mention the two different fundamental ways of SUCI calculation (on card / on UE) and mention that this is only about the "on UE" variant? https://gerrit.osmocom.org/c/pysim/+/32688/comment/5901d94a_7b4b6403 PS1, Line 33: If you bought : the SIM card from your network maybe make it more explicit that this only works with a programmable card where you as the pySim user are functioning as the card issuer/operator? https://gerrit.osmocom.org/c/pysim/+/32688/comment/003cba4f_46f45733 PS1, Line 103: file is **invalid**: does the file contain invalid data, or do you mean it is invalidated (other term for deactivated)? https://gerrit.osmocom.org/c/pysim/+/32688/comment/fe40ee9c_7bb0fda7 PS1, Line 120: pySIM-shell (MF/ADF misc comment: this probably means we should add a decoder/encoder for this file, so people don't have to go through hex strings. https://gerrit.osmocom.org/c/pysim/+/32688/comment/4c4dad8e_cb38832d PS1, Line 168: sysmocom ISIM does best to always say "sysmoISIM-SJA2" as other products in the future may also be a "sysmocom ISIM" but have different feature sets. Same applies below in the next few lines until EOF. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32688 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2908ea9df7e78c596554731085902e2ab7278328 Gerrit-Change-Number: 32688 Gerrit-PatchSet: 1 Gerrit-Owner: merlinchlosta <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: merlinchlosta <[email protected]> Gerrit-Comment-Date: Fri, 12 May 2023 15:10:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: merlinchlosta <[email protected]> Gerrit-MessageType: comment
