Attention is currently required from: lynxis lazus, matanp.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/32712 )

Change subject: Add FPLMN read and program
......................................................................


Patch Set 5:

(1 comment)

File pysim-testdata/sysmoUSIM-SJS1.ok:

https://gerrit.osmocom.org/c/pysim/+/32712/comment/62e15cd9_e67814fc
PS5, Line 108:  62f201 # MCC: 262 MNC: 010
> I wonder how the 2 digit and 3 digit mnc is differentiated. […]
Related: see osmo_mnc_name_buf()

numbers > 99 are always 3 digits.
- 2 digit < 99: repsentation 01..99
- 3 digit < 99: representation 001..099.

So this MNCs shown here should be 3 digit according to what I mention.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/32712
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b
Gerrit-Change-Number: 32712
Gerrit-PatchSet: 5
Gerrit-Owner: matanp <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Attention: matanp <[email protected]>
Gerrit-Comment-Date: Fri, 26 May 2023 11:07:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <[email protected]>
Gerrit-MessageType: comment

Reply via email to