Attention is currently required from: pespin, lynxis lazus, matanp. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/32712 )
Change subject: Add FPLMN read and program ...................................................................... Patch Set 6: (1 comment) File pysim-testdata/sysmoUSIM-SJS1.ok: https://gerrit.osmocom.org/c/pysim/+/32712/comment/48fb5fb9_7ad8370a PS5, Line 108: 62f201 # MCC: 262 MNC: 010 > The only solution I can see is changing `derive_mcc` and `derive_mnc` to > return a 'str' instead of ' […] I would think so. In general, it's bad practice to use integer for mcc/mnc values exactly for that reason. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/32712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ce8c1af691c28ea9ed69e7b5f03f0c02d1f029b Gerrit-Change-Number: 32712 Gerrit-PatchSet: 6 Gerrit-Owner: matanp <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: lynxis lazus <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Attention: matanp <[email protected]> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:11:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: lynxis lazus <[email protected]> Comment-In-Reply-To: matanp <[email protected]> Gerrit-MessageType: comment
