Attention is currently required from: laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33087 )

Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc
......................................................................


Patch Set 2:

(5 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/7e9999d8_45f9eda0
PS2, Line 17: always 256bit, but K can bei 128 or 256 bits.  So we need separate
can be


https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/365ca87a_c76725c5
PS2, Line 27: are modified in an incompatible way.
(in case you didn't: write in TODO-RELEASE).


File include/osmocom/crypt/auth.h:

https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/139042ac_053db30a
PS2, Line 119: int osmo_auth_gen_vec(struct osmo_auth_vector *vec,
mark as deprecated.


https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/5f7fc4cb_183a16ee
PS2, Line 125: int osmo_auth_gen_vec_auts(struct osmo_auth_vector *vec,
mark as deprecated.


File src/gsm/auth_core.c:

https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/76036791_755a3c45
PS2, Line 235:  * This function performs a special variant of the  core 
cryptographic
extra space "the  core"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df
Gerrit-Change-Number: 33087
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 30 May 2023 15:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to