Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33087 )
Change subject: libosmogsm: Support authentication with 256-bit K and/or OP/OPc ...................................................................... Patch Set 2: (5 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/0dce5a9e_d740dc01 PS2, Line 17: always 256bit, but K can bei 128 or 256 bits. So we need separate > can be Done https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/2d589819_e5e359a6 PS2, Line 27: are modified in an incompatible way. > (in case you didn't: write in TODO-RELEASE). Done File include/osmocom/crypt/auth.h: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/c0038db7_95a18a50 PS2, Line 119: int osmo_auth_gen_vec(struct osmo_auth_vector *vec, > mark as deprecated. Done https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/c42164a3_c38e4623 PS2, Line 125: int osmo_auth_gen_vec_auts(struct osmo_auth_vector *vec, > mark as deprecated. Done File src/gsm/auth_core.c: https://gerrit.osmocom.org/c/libosmocore/+/33087/comment/0eb5d1d5_30b0137d PS2, Line 235: * This function performs a special variant of the core cryptographic > extra space "the core" Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33087 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie775fedba4a3fa12314c0f7c8a369662ef6a40df Gerrit-Change-Number: 33087 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 30 May 2023 19:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
