Attention is currently required from: neels, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 )

Change subject: tweak lots of logging
......................................................................


Patch Set 5: Code-Review+1

(2 comments)

File src/osmo-hnbgw/hnbgw_cn.c:

https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/0aae164f_0d85e75b
PS3, Line 583:                  hnbgw_cnlink_log_self(cnlink);
what do I mean with extra log line? see here for instance, you end printing 
twice, in line 581 and in line 583.


https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/5c86bbd7_f63c8ea1
PS3, Line 635:  hnbgw_cnlink_log_self(cnlink);
same here with line 612



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06
Gerrit-Change-Number: 33171
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Attention: laforge <lafo...@osmocom.org>
Gerrit-Comment-Date: Thu, 08 Jun 2023 08:19:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to