Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 )
Change subject: tweak lots of logging ...................................................................... Patch Set 7: (1 comment) File src/osmo-hnbgw/hnbgw_cn.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171/comment/2734f3ed_06f27d8a PS3, Line 515: LOG_CNLINK(cnlink, DCN, LOGL_NOTICE, "using: cs7-%u %s <-> %s %s %s\n", > multi-line logging is allways a PITA from the point of anyone trying to > process log files. […] I am not using multi line logging here ... ? (and i am very aware that they must not be used) I initially had no idea what Pau meant by the comment: "This would rpboably better with a couple defines _FMT and _ARGS, so that it ends up in same log line and not in an extra one." In the meantime, it has become clear that Pau means the LOG_CNLINK(LOGL_DEBUG) in line 581, followed by calling hnbgw_cnlink_log_self() which will LOG_CNLINK(LOGL_NOTICE) right after that. I've explained that there is a minor detail being logged on DEBUG, followed by a very pivotal log line on NOTICE. These log lines are separate on purpose, and they should both be there; by my explicit choice made from reading log output and making sure that all the interesting bits show, while still ensuring a useful log on more quiet log levels. The DEBUG log is part of a family of log lines aimed at "tracing" all the ss7 and sccp instance decisions, it should not clutter the NOTICE log. The NOTICE log is a marker showing at which point in time the cnlink is fully configured for the first time. I am still not clear what Pau means by "with a couple defines _FMT and _ARGS", I guessed the source file and line info. If yes, my response is that this log line happens only at program startup and happens exactly once per cnlink, so carrying the caller's source file+line info is not important. It is aimed at telling the user the resolved cnlink config; the DEBUG log is aimed at indicating which code path chose that config and why. I have specifically made these choices on purpose, and it seems there is a misunderstanding in the code review? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/33171 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I41275d8c3e272177976a9302795884666c35cd06 Gerrit-Change-Number: 33171 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Fri, 16 Jun 2023 02:54:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
