Patch Set 13: (2 comments)
https://gerrit.osmocom.org/#/c/4980/13/src/libmsc/iucs.c File src/libmsc/iucs.c: Line 224: LOGP(DIUCS, LOGL_DEBUG, (here's another candidate for a common LOGPFOO() context macro ... probably also applies for the rest of this file; so I'd pass this patch without one and change over to a proper macro separately) https://gerrit.osmocom.org/#/c/4980/13/src/libmsc/iucs_ranap.c File src/libmsc/iucs_ranap.c: Line 53: printf("transportLayerAddress present!\n"); -1: drop the printf, but I know you're working on that FIXME at the moment, so waiting for the next patch set. -- To view, visit https://gerrit.osmocom.org/4980 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea9630358b3963261fa1993cf1f3b563ff23538 Gerrit-PatchSet: 13 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
