Patch Set 4: (2 comments)
https://gerrit.osmocom.org/#/c/4893/4/src/osmo_ss7.c File src/osmo_ss7.c: Line 426: /*! \brief bind all xUA servers belonging to an SS7 Instance don't add new \brief, we use AUTOBRIEF (see Doxyfile). Just make sure the first sentence ends in a '.' Line 1792: osmo_ss7_xua_server_create(struct osmo_ss7_instance *inst, enum osmo_ss7_asp_protocol proto, to keep the public API backwards compatible, you should rather introduce osmo_ss7_xua_server_create2(), keeping osmo_ss7_xua_server_create() behavior identical but deprecating it (call osmo_ss7_xua_server_create2() and then open the link on it). The advantage is that we can migrate dependent code at any time without breaking anything until we do. (but... we don't need any more patches in osmo-msc and osmo-bsc, right? because the vty changes are in here?) -- To view, visit https://gerrit.osmocom.org/4893 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79738963d633bec70705ff159c5b2127cd498aa2 Gerrit-PatchSet: 4 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-HasComments: Yes
