Attention is currently required from: arehbein.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33346 )

Change subject: core/osmo_io: Fix reception of partial packets
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I don't really understand this patch (but then I'm not an expert in the new 
osmo_io code).  But in a newly-allocated msgb head == tail. So why not always 
append to the tail of the message in the call-back?  I don't undertand why 
another new variable is needed.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33346
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0ab8028c807b4181fddd3c00ea2e037c40cf0813
Gerrit-Change-Number: 33346
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Comment-Date: Sat, 17 Jun 2023 05:51:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to