Attention is currently required from: arehbein.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33346 )

Change subject: core/osmo_io: Fix reception of partial packets
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File src/core/osmo_io_poll.c:

https://gerrit.osmocom.org/c/libosmocore/+/33346/comment/7fba8b2c_1b86ee62
PS1, Line 59: iofd
IMHO, the unconditional iov_base = msg->tail should do the trick here.  In fact 
I would even argue msgb_data is wrong, as we below are using the _tailroom_ as 
length.  So data == tail and length == tailroom.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33346
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0ab8028c807b4181fddd3c00ea2e037c40cf0813
Gerrit-Change-Number: 33346
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Comment-Date: Sat, 17 Jun 2023 05:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to