Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33446 )

Change subject: ASCI: Add decoding of mobile identity in TALKER INDICATION
......................................................................


Patch Set 1:

(2 comments)

File src/gsm/gsm48.c:

https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/19df938c_4767779f
PS1, Line 959:                  if (l3_len < sizeof(*gh) + 4 + 2)
what are this offsets?


https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/4e9bfc30_1281350f
PS1, Line 961:                  if (gh->data[0] != 3)
what's this value about?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33446
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d
Gerrit-Change-Number: 33446
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Mon, 26 Jun 2023 08:56:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to