Attention is currently required from: pespin.

jolly has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/33446 )

Change subject: ASCI: Add decoding of mobile identity in TALKER INDICATION
......................................................................


Patch Set 2:

(2 comments)

File src/gsm/gsm48.c:

https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/8d5a4ea3_a9509c38
PS1, Line 959:                  if (l3_len < sizeof(*gh) + 4 + 2)
> This is the minimum message size according to TS 44.018  9.1.44.
Done


https://gerrit.osmocom.org/c/libosmocore/+/33446/comment/bc56ff66_6d9f1000
PS1, Line 961:                  if (gh->data[0] != 3)
> This is the fixed length of the first IE.
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33446
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I331fac82e3c15abb01f554b2e70576100f2eea2d
Gerrit-Change-Number: 33446
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 26 Jun 2023 10:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to