Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488 )
Change subject: hnbgw: add mscpool paging tests ...................................................................... Patch Set 1: (1 comment) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488/comment/e2590b00_cc20954d PS1, Line 2296: RUA Emulation forwards those RUA Unitdata only to the ranap_unitdata_cb As far as I can see, RUA_Emulation calls whatever unitdata callback was registered by the user of RUA_Emulation. As far as I can see IuhRanapUnitdataCallback() doesn't really do anything with it so far? The comment reads a bit as there is a missing feature in the RUA emulation. To me it seems the omission is more on the user side of the RUA emulation, as it doesn't register a meaningful call-back. Or do you think that the RUA emulation itself should do anything with those unitdata messages? Like parsing a paging, matching the mobile identity and dispatching it to the respective CLIENT? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4bbd5c970108b01e8556fa7744ff627db75fb13 Gerrit-Change-Number: 33488 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Thu, 29 Jun 2023 08:20:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
