Attention is currently required from: laforge.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488 )

Change subject: hnbgw: add mscpool paging tests
......................................................................


Patch Set 1:

(1 comment)

File hnbgw/HNBGW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488/comment/50ad76d1_91ff0dea
PS1, Line 2296: RUA Emulation forwards those RUA Unitdata only to the 
ranap_unitdata_cb
> As far as I can see, RUA_Emulation calls whatever unitdata callback was 
> registered by the user of RU […]
this meaning is intended: we could handle the Paging with some effort,
but since we do not really care about the Paging message in this test, just 
leave it.

What sounds like a "missing feature" is an inconvenience: there is only one 
Unitdata callback, and communicating a call of this callback into the 
f_tc_foo() test case component isn't so trivial. It could be changed, but that 
comment shouldn't be there i guess.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33488
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If4bbd5c970108b01e8556fa7744ff627db75fb13
Gerrit-Change-Number: 33488
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 04 Jul 2023 02:54:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to