Attention is currently required from: laforge, pespin, keith.

dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )

Change subject: e1d: reconnect to osmo-e1d after connection loss
......................................................................


Patch Set 13:

(2 comments)

File src/input/e1d.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/55de0a3a_9384d756
PS11, Line 340:                 osmo_fsm
> you would normally need to buffer any partial-read and wait until the 
> remainder of the data is recei […]
Done


https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/e1a22b5f_bd0d5be0
PS11, Line 391:                 osmo_fsm
> well, now you are dropping the data. […]
Thanks for the detailed explanation. I have now added a FIXME note. As far as I 
understand this problem already existed before this patch as well.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 13
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: keith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-CC: tnt <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: keith <[email protected]>
Gerrit-Comment-Date: Tue, 04 Jul 2023 11:40:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: dexter <[email protected]>
Gerrit-MessageType: comment

Reply via email to