Attention is currently required from: pespin, keith, dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/32374 )

Change subject: e1d: reconnect to osmo-e1d after connection loss
......................................................................


Patch Set 14: Code-Review+1

(1 comment)

File src/input/e1d.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/32374/comment/155aac74_c9b45630
PS14, Line 401:                 /* FIXME: The socket that we write to is of 
type SOCK_STREAM. This means that it may happen that the
> using a wqueue should fix this afaiu.
yes, but that's an orthogonal change to the one introduced here.  Even the 
previous code had the issue that's described here.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/32374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 14
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: keith <[email protected]>
Gerrit-CC: tnt <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: keith <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 04 Jul 2023 15:39:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to