Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/33499 )

Change subject: ASCI: rtp_stream_commit(): Also update MGW on conn mode change
......................................................................


Patch Set 7:

(1 comment)

File src/libmsc/rtp_stream.c:

https://gerrit.osmocom.org/c/osmo-msc/+/33499/comment/d301e420_a1400002
PS7, Line 440:  if (rtps->crcx_conn_mode != mode)
This really needs to be moved to the top of the function, and early return in 
order to trigger all the stuff below it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33499
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I7a5637d0a7f1df13133e522fc78ba75eeeb2873e
Gerrit-Change-Number: 33499
Gerrit-PatchSet: 7
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: neels <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 06 Jul 2023 12:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to