Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630 )
Change subject: library/RAN_Emulation: testcase.stop -> mtc.stop
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I am wondering if we can use `Misc_Helpers.f_shutdown` instead? It's used
> once in this file.
Reading `Misc_Helpers.f_shutdown`, it will evaluate to the same
`setverdict(fail, …)` and `mtc.stop`, except that it also prints this log line:
`log("Stopping testcase execution from ", file, ":", line)`.
So yes we can use it instead, but personally I don't think the extra log line
is that useful and I think the separate `setverdict`and `mtc.stop` lines look
more elegant than this long line: `Misc_Helpers.f_shutdown(__BFILE__, __LINE__,
fail, "…");`. Also the separate `setverdict` + `mtc.stop` lines are already
used a lot throughout the file. So I'd prefer to keep the patch as-is.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33630
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8923975f6cb48f5f628e2ac5dc412f0f3ab97aab
Gerrit-Change-Number: 33630
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 07 Jul 2023 11:35:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment
